Liraz Siri's picture

FWIW, I made the hotpatch rely on matching 'fab-dev' within the ecdsa key not because it's the right thing to do but because it was better than matching a specific fingerprint or timestamp, which also wouldn't have worked with custom builds. It's a hack.

I grepped through the common/ repo and couldn't find any other instances where we rely on the hostname, certainly not on fab-dev.

In case you're wondering where the name fab-dev comes from, it's the hostname for the master tkldev instance. It's basically tkldev with the latest versions of all the repositories + various security sensitive credentials needed to upload images to S3 or to the master rsync server.

The way we build TurnKey is that we first test the Core build and conversions on fab-dev, the tkldev master. Then we snapshot fab-dev and clone it as many times as needed using cloudtask so that the build/conversions run in parallel.